Repository navigation
P20: a new Tests report is shown, not appended out of view - #34
Merged
Merged
Conversation
After a Tests run with failures, «Tests» looked dead once the code was edited: the button was enabled and the second run tested the edited code, but since the console became one transcript (P18) the new report is appended below the previous one - and a learner who scrolled up to read the first report doesn't see it arrive. ▶ Ausführen "fixed" it by clearing the console. The console still follows streamed output only while it is at its end, but an entry a click asked for - a Tests report, a REPL input, the stop note - scrolls the console to that entry's start (the report's summary first), setting the console's scrollTop only. test:console (scripts/check-console-browser.mjs, in CI): Tests → fail → edit → Tests and Tests → pass → edit → Tests, with the console scrolled up in between, run the edited code and show its report. Drives the built embed in Chrome through its protocol, with Pyodide; fails without the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes P20: after a Tests run with a failing example, «Tests» seemed not to react once the code was edited, until ▶ Ausführen.
What was going on
I reproduced it in the course embed (the real Etappe 2 page, «Aufgabe 1: Doctests lesen», profile rezept) and in the IDE.
glpython:testwith the edited code, the embed runs it, andglpython:busygoestrue→false. The report says «4 von 5» instead of «3 von 5».Fix (
GlPythonWorkspace.tsx)scrollTopis set.scrollIntoViewwould scroll the LiaScript page too.Regression test, in CI
npm run test:console(scripts/check-console-browser.mjs):playwright-coredrives Chrome (GitHub's ubuntu runner has it) againstvite previewofdist-embed/, through the embed protocol, with Pyodide from its CDN. It is the first browser check in CI; CLAUDE.md is updated.main's build the first scenario fails («the new report's summary is in the console's view»); with this PR both pass.IDE, same steps (Tests, scroll up, paste the edited code, Tests):
main: the button is enabled, the run gives «1 von 4», and the report is out of view.Lint (known warning only), both builds,
test:protocol,test:hints,test:runtimeandtest:consolepass locally. After the merge: tag v0.1.14 and bump the IDE.🤖 Generated with Claude Code